Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore) Use quietDeps option with SASS loader #416

Merged
merged 1 commit into from
May 3, 2022
Merged

(chore) Use quietDeps option with SASS loader #416

merged 1 commit into from
May 3, 2022

Conversation

brandones
Copy link
Collaborator

Requirements

  • This PR has a title that briefly describes the work done, including the ticket number if there is a ticket.

For changes to apps

If applicable

  • My work includes tests or is validated by existing tests.
  • I have updated the esm-framework mock to reflect any API changes I have made.

Summary

Gets rid of all that annoying log output when running things.

Screenshots

Screenshot from 2022-05-02 17-59-24

@brandones brandones requested a review from ibacher May 3, 2022 00:59
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2022

File size impact

Merging quiet-sass into master impact files as follow:

@openmrs/esm-devtools-app (no impact)
Files new size
Unmodified (5) 481 kB (0 B / +0%) 👻
Total (5) 481 kB (0 B / +0%) 👻
@openmrs/esm-implementer-tools-app (no impact)
Files new size
packages/apps/esm-implementer-tools-app/dist/475.js 233 kB 👶
packages/apps/esm-implementer-tools-app/dist/105.js 25 kB 👶
packages/apps/esm-implementer-tools-app/dist/531.js 3.27 kB 👶
packages/apps/esm-implementer-tools-app/dist/781.js deleted (-3.27 kB)
packages/apps/esm-implementer-tools-app/dist/843.js deleted (-25 kB)
packages/apps/esm-implementer-tools-app/dist/586.js deleted (-233 kB)
packages/apps/esm-implementer-tools-app/dist/284.js 3.37 kB (0 B / +0%) 👻
packages/apps/esm-implementer-tools-app/dist/811.js 6.4 kB (0 B / +0%) 👻
packages/apps/esm-implementer-tools-app/dist/openmrs-esm-implementer-tools-app.js 11.6 kB (0 B / +0%) 👻
Unmodified (16) 2.15 MB (0 B / +0%) 👻
Total (25) 2.44 MB (0 B / +0%) 👻
@openmrs/esm-login-app (+0%)
Files new size
packages/apps/esm-login-app/dist/399.js 93.7 kB 👶
packages/apps/esm-login-app/dist/607.js 90.4 kB 👶
packages/apps/esm-login-app/dist/406.js 82.7 kB 👶
packages/apps/esm-login-app/dist/951.js 81 kB 👶
packages/apps/esm-login-app/dist/openmrs-esm-login-app.js 12.1 kB (+2 B / +0.02%) ↗️
packages/apps/esm-login-app/dist/420.js 3.92 kB (+1 B / +0.03%) ↗️
packages/apps/esm-login-app/dist/37.js deleted (-81 kB)
packages/apps/esm-login-app/dist/483.js deleted (-82.7 kB)
packages/apps/esm-login-app/dist/481.js deleted (-90.4 kB)
packages/apps/esm-login-app/dist/531.js deleted (-93.7 kB)
Unmodified (23) 1.72 MB (0 B / +0%) 👻
Total (33) 2.08 MB (+1 B / +0%) ↗️
@openmrs/esm-offline-tools-app (-0%)
Files new size
packages/apps/esm-offline-tools-app/dist/903.js 258 kB 👶
packages/apps/esm-offline-tools-app/dist/275.js 166 kB 👶
packages/apps/esm-offline-tools-app/dist/126.js 117 kB 👶
packages/apps/esm-offline-tools-app/dist/991.js 112 kB 👶
packages/apps/esm-offline-tools-app/dist/827.js 107 kB 👶
packages/apps/esm-offline-tools-app/dist/895.js 84.9 kB 👶
packages/apps/esm-offline-tools-app/dist/639.js 84.2 kB 👶
packages/apps/esm-offline-tools-app/dist/319.js 82.5 kB 👶
packages/apps/esm-offline-tools-app/dist/530.js 25.8 kB 👶
packages/apps/esm-offline-tools-app/dist/openmrs-esm-offline-tools-app.js 93.3 kB (+2 B / +0%) ↗️
packages/apps/esm-offline-tools-app/dist/446.js deleted (-25.8 kB)
packages/apps/esm-offline-tools-app/dist/865.js deleted (-82.5 kB)
packages/apps/esm-offline-tools-app/dist/749.js deleted (-84.2 kB)
packages/apps/esm-offline-tools-app/dist/705.js deleted (-84.9 kB)
packages/apps/esm-offline-tools-app/dist/926.js deleted (-107 kB)
packages/apps/esm-offline-tools-app/dist/441.js deleted (-112 kB)
packages/apps/esm-offline-tools-app/dist/362.js deleted (-117 kB)
packages/apps/esm-offline-tools-app/dist/658.js deleted (-166 kB)
packages/apps/esm-offline-tools-app/dist/368.js deleted (-258 kB)
packages/apps/esm-offline-tools-app/dist/316.js 1.71 kB (0 B / +0%) 👻
packages/apps/esm-offline-tools-app/dist/412.js 3.34 kB (0 B / +0%) 👻
Unmodified (16) 1.7 MB (0 B / +0%) 👻
Total (37) 2.84 MB (-1 B / -0%) ↘️
@openmrs/esm-primary-navigation-app (-0%)
Files new size
packages/apps/esm-primary-navigation-app/dist/212.js 247 kB 👶
packages/apps/esm-primary-navigation-app/dist/510.js 83.6 kB 👶
packages/apps/esm-primary-navigation-app/dist/540.js 78.5 kB 👶
packages/apps/esm-primary-navigation-app/dist/789.js 32.1 kB (-1 B / -0%) ↘️
packages/apps/esm-primary-navigation-app/dist/openmrs-esm-primary-navigation-app.js 40.8 kB (-1 B / -0%) ↘️
packages/apps/esm-primary-navigation-app/dist/964.js deleted (-78.5 kB)
packages/apps/esm-primary-navigation-app/dist/418.js deleted (-83.6 kB)
packages/apps/esm-primary-navigation-app/dist/877.js deleted (-247 kB)
Unmodified (13) 1.7 MB (0 B / +0%) 👻
Total (21) 2.18 MB (-5 B / -0%) ↘️
@openmrs/esm-app-shell (+0%)
Files new size
packages/shell/esm-app-shell/dist/service-worker.js 201 kB (+1 B / +0%) ↗️
packages/shell/esm-app-shell/dist/openmrs.js 1.46 MB (0 B / +0%) 👻
Unmodified (2) 540 kB (0 B / +0%) 👻
Total (4) 2.2 MB (+1 B / +0%) ↗️
Generated by @jsenv/file-size-impact during Report bundle size#2261318284 on 6feb100

@brandones brandones requested a review from ZacButko May 3, 2022 14:25
@brandones brandones merged commit de440e7 into master May 3, 2022
@brandones brandones deleted the quiet-sass branch May 3, 2022 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacButko ZacButko ZacButko approved these changes

@ibacher ibacher Awaiting requested review from ibacher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandones @ZacButko